This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Move parseSpecification and parseImplementation outside of let rec #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
force-pushed
the
make-entrypoint-functions-non-rec
branch
from
149d0a6 to
b4f7418
Compare
cristianoc
reviewed
Jun 1, 2022
| (* module signature on the file level *) | ||
| let parseSpecification p : Parsetree.signature = | ||
| parseRegion p ~grammar:Grammar.Specification ~f:parseSignatureItemRegion | ||
| [@@progress (Parser.next, Parser.expect, Parser.checkProgress)] |
There was a problem hiding this comment.
These annotations go on recursive functions, or the check won't fire.
Moved to parseSignatureItemRegion and parseStructureItemRegion in a PR.
There was a problem hiding this comment.
Oops, sorry about merging so eagerly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.